Unverified Commit 3dbb3eef authored Mar 30, 2018 by Alexey Khoroshilov Committed by Mark Brown Apr 17, 2018

spi: stm32: Fix error handling in stm32_spi_probe()



clk_get_rate() is below clk_prepare_enable(), so
its error should lead to goto err_clk_disable, not to err_master_put.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 10b46408

drivers/spi/spi-stm32.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1129,7 +1129,7 @@ static int stm32_spi_probe(struct platform_device *pdev)
		if (!spi->clk_rate) {
		dev_err(&pdev->dev, "clk rate = 0\n");
		ret = -EINVAL;
		goto err_master_put;
		goto err_clk_disable;
		}

		spi->rst = devm_reset_control_get_exclusive(&pdev->dev, NULL);