Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 3da9834d authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Mark Brown
Browse files

spi: dw-mmio: Clock should be shut when error occurs 



When optional clock requesting fails, the main clock is still up and running,
we should shut it down in such caee.

Fixes: 560ee7e9 ("spi: dw: Add support for an optional interface clock")
Cc: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Gareth Williams <gareth.williams.jx@renesas.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGareth Williams <gareth.williams.jx@renesas.com>
Link: https://lore.kernel.org/r/20190710114243.30101-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 05210502

drivers/spi/spi-dw-mmio.c

+4 −2
Original line number Diff line number Diff line
@@ -170,8 +170,10 @@ static int dw_spi_mmio_probe(struct platform_device *pdev) 


	/* Optional clock needed to access the registers */

	dwsmmio->pclk = devm_clk_get_optional(&pdev->dev, "pclk");

	if (IS_ERR(dwsmmio->pclk))

		return PTR_ERR(dwsmmio->pclk);

	if (IS_ERR(dwsmmio->pclk)) {

		ret = PTR_ERR(dwsmmio->pclk);

		goto out_clk;

	}

	ret = clk_prepare_enable(dwsmmio->pclk);

	if (ret)

		goto out_clk;