Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d67be27 authored by Horia Geanta's avatar Horia Geanta Committed by Herbert Xu
Browse files

crypto: caam - fix mem leak in ahash_setkey 



In case hash key is bigger than algorithm block size, it is hashed.
In this case, memory is allocated to keep this hash in hashed_key.
hashed_key has to be freed on the key_dma dma mapping error path.

Signed-off-by: default avatarHoria Geanta <horia.geanta@freescale.com>
Reviewed-by: default avatarMarek Vasut <marex@denx.de>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f51f593b

drivers/crypto/caam/caamhash.c

+3 −1
Original line number Diff line number Diff line
@@ -545,7 +545,8 @@ static int ahash_setkey(struct crypto_ahash *ahash, 
				      DMA_TO_DEVICE);

	if (dma_mapping_error(jrdev, ctx->key_dma)) {

		dev_err(jrdev, "unable to map key i/o memory\n");

		return -ENOMEM;

		ret = -ENOMEM;

		goto map_err;

	}

#ifdef DEBUG

	print_hex_dump(KERN_ERR, "ctx.key@"__stringify(__LINE__)": ",
@@ -559,6 +560,7 @@ static int ahash_setkey(struct crypto_ahash *ahash, 
				 DMA_TO_DEVICE);

	}



map_err:

	kfree(hashed_key);

	return ret;

badkey: