Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3d664b07 authored by Geert Uytterhoeven's avatar Geert Uytterhoeven Committed by Bjorn Helgaas
Browse files

PCI: rcar: Don't disable/unprepare clocks on prepare/enable failure 



If clk_prepare_enable() fails, we must not call clk_disable_unprepare() in
the error path.

Signed-off-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 51afa3cc

drivers/pci/host/pcie-rcar.c

+2 −2
Original line number Diff line number Diff line
@@ -786,7 +786,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev, 
	}

	err = clk_prepare_enable(pcie->clk);

	if (err)

		goto fail_clk;

		return err;



	pcie->bus_clk = devm_clk_get(&pdev->dev, "pcie_bus");

	if (IS_ERR(pcie->bus_clk)) {
@@ -796,7 +796,7 @@ static int rcar_pcie_get_resources(struct platform_device *pdev, 
	}

	err = clk_prepare_enable(pcie->bus_clk);

	if (err)

		goto err_map_reg;

		goto fail_clk;



	i = irq_of_parse_and_map(pdev->dev.of_node, 0);

	if (!i) {