Commit 3cf8ece9 authored May 12, 2022 by Miaoqian Lin Committed by Greg Kroah-Hartman Jul 12, 2022

ARM: meson: Fix refcount leak in meson_smp_prepare_cpus



[ Upstream commit 34d2cd3fccced12b958b8848e3eff0ee4296764c ]

of_find_compatible_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: d850f3e5 ("ARM: meson: Add SMP bringup code for Meson8 and Meson8b")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20220512021611.47921-1-linmq006@gmail.com


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent c465bbcd

arch/arm/mach-meson/platsmp.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -71,6 +71,7 @@ static void __init meson_smp_prepare_cpus(const char *scu_compatible,
		}

		sram_base = of_iomap(node, 0);
		of_node_put(node);
		if (!sram_base) {
		pr_err("Couldn't map SRAM registers\n");
		return;
		@@ -91,6 +92,7 @@ static void __init meson_smp_prepare_cpus(const char *scu_compatible,
		}

		scu_base = of_iomap(node, 0);
		of_node_put(node);
		if (!scu_base) {
		pr_err("Couldn't map SCU registers\n");
		return;