Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cf72922 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

SUNRPC: Replace division by multiplication in calculation of queue length 



When checking whether or not a particular xprt queue length is shorter
than the average queue length for all xprts, prefer to use multiplication
rather than division for performance reasons.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent 50c80007

net/sunrpc/xprtmultipath.c

+2 −3
Original line number Diff line number Diff line
@@ -322,7 +322,6 @@ struct rpc_xprt *xprt_iter_next_entry_roundrobin(struct rpc_xprt_iter *xpi) 
	struct rpc_xprt *xprt;

	unsigned long xprt_queuelen;

	unsigned long xps_queuelen;

	unsigned long xps_avglen;



	do {

		xprt = xprt_iter_next_entry_multiple(xpi,
@@ -333,8 +332,8 @@ struct rpc_xprt *xprt_iter_next_entry_roundrobin(struct rpc_xprt_iter *xpi) 
		if (xprt_queuelen <= 2)

			break;

		xps_queuelen = atomic_long_read(&xps->xps_queuelen);

		xps_avglen = DIV_ROUND_UP(xps_queuelen, xps->xps_nactive);

	} while (xprt_queuelen > xps_avglen);

		/* Exit loop if xprt_queuelen <= average queue length */

	} while (xprt_queuelen * READ_ONCE(xps->xps_nactive) > xps_queuelen);

	return xprt;

}