Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c69b66b authored by Israel Schlesinger's avatar Israel Schlesinger Committed by Raghavendra Rao Ananta
Browse files

checkpatch: Add warnings for use of mdelay() 



Discourage the use of mdelay(), and use msleep() instead.

Change-Id: I99f44fc632df4b371bc8633005d57c220ece1001
Signed-off-by: default avatarIsrael Schlesinger <israels@codeaurora.org>
(cherry picked from commit 084af58596758be6e51ef060aefa2cd622dc9205)
Signed-off-by: default avatarStepan Moskovchenko <stepanm@codeaurora.org>
Signed-off-by: default avatarRaghavendra Rao Ananta <rananta@codeaurora.org>
parent b6439972

scripts/checkpatch.pl

+6 −0
Original line number Diff line number Diff line
@@ -5741,6 +5741,12 @@ sub process { 
			     "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);

		}



# check the patch for use of mdelay

		if ($line =~ /\bmdelay\s*\(/) {

			WARN("MDELAY",

			     "use of mdelay() found: msleep() is the preferred API.\n" . $herecurr );

		}



# warn about #ifdefs in C files

#		if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {

#			print "#ifdef in C files should be avoided\n";