Commit 3c576de3 authored Sep 04, 2018 by Jakub Kicinski Committed by David S. Miller Sep 05, 2018

nfp: fix readq on absolute RTsyms



Return the error and report value through the output param.

Fixes: 640917dd ("nfp: support access to absolute RTsyms")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Reviewed-by: Francois H. Theron <francois.theron@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9e7e6cab

drivers/net/ethernet/netronome/nfp/nfpcore/nfp_rtsym.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -337,8 +337,10 @@ int __nfp_rtsym_readq(struct nfp_cpp cpp, const struct nfp_rtsym sym,
		u64 addr;
		int err;

		if (sym->type == NFP_RTSYM_TYPE_ABS)
		return sym->addr;
		if (sym->type == NFP_RTSYM_TYPE_ABS) {
		*value = sym->addr;
		return 0;
		}

		err = nfp_rtsym_to_dest(cpp, sym, action, token, off, &cpp_id, &addr);
		if (err)