Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c40dfeb authored by Takashi Iwai's avatar Takashi Iwai
Browse files

ALSA: drivers: Remove superfluous snd_pcm_suspend*() calls 



The call of snd_pcm_suspend_all() & co became superfluous since we
call it in the PCM PM ops.  Let's remove them.

Reviewed-by: default avatarJaroslav Kysela <perex@perex.cz>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
parent 28394f0e

sound/drivers/aloop.c

+0 −4
Original line number Diff line number Diff line
@@ -1200,12 +1200,8 @@ static int loopback_remove(struct platform_device *devptr) 
static int loopback_suspend(struct device *pdev)

{

	struct snd_card *card = dev_get_drvdata(pdev);

	struct loopback *loopback = card->private_data;



	snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);



	snd_pcm_suspend_all(loopback->pcm[0]);

	snd_pcm_suspend_all(loopback->pcm[1]);

	return 0;

}

sound/drivers/dummy.c

+0 −2
Original line number Diff line number Diff line
@@ -1138,10 +1138,8 @@ static int snd_dummy_remove(struct platform_device *devptr) 
static int snd_dummy_suspend(struct device *pdev)

{

	struct snd_card *card = dev_get_drvdata(pdev);

	struct snd_dummy *dummy = card->private_data;



	snd_power_change_state(card, SNDRV_CTL_POWER_D3hot);

	snd_pcm_suspend_all(dummy->pcm);

	return 0;

}

sound/drivers/pcsp/pcsp.c

+0 −1
Original line number Diff line number Diff line
@@ -197,7 +197,6 @@ static int pcsp_suspend(struct device *dev) 
{

	struct snd_pcsp *chip = dev_get_drvdata(dev);

	pcsp_stop_beep(chip);

	snd_pcm_suspend_all(chip->pcm);

	return 0;

}

sound/drivers/vx/vx_core.c

+0 −4
Original line number Diff line number Diff line
@@ -732,12 +732,8 @@ EXPORT_SYMBOL(snd_vx_dsp_load); 
 */

int snd_vx_suspend(struct vx_core *chip)

{

	unsigned int i;



	snd_power_change_state(chip->card, SNDRV_CTL_POWER_D3hot);

	chip->chip_status |= VX_STAT_IN_SUSPEND;

	for (i = 0; i < chip->hw->num_codecs; i++)

		snd_pcm_suspend_all(chip->pcm[i]);



	return 0;

}