Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3be7ae63 authored by Sebastian Ott's avatar Sebastian Ott Committed by Martin Schwidefsky
Browse files

s390/ipl: cleanup macro usage 



ipl.c uses 3 different macros to create a sysfs show function for ipl
attributes. Define IPL_ATTR_SHOW_FN which is used by all macros.

Reviewed-by: default avatarMichael Holzheu <holzheu@linux.vnet.ibm.com>
Signed-off-by: default avatarSebastian Ott <sebott@linux.vnet.ibm.com>
Signed-off-by: default avatarMartin Schwidefsky <schwidefsky@de.ibm.com>
parent 0f024379

arch/s390/kernel/ipl.c

+11 −19
Original line number Diff line number Diff line
@@ -182,24 +182,21 @@ EXPORT_SYMBOL_GPL(diag308); 


/* SYSFS */



#define DEFINE_IPL_ATTR_RO(_prefix, _name, _format, _value)		\

#define IPL_ATTR_SHOW_FN(_prefix, _name, _format, args...)		\

static ssize_t sys_##_prefix##_##_name##_show(struct kobject *kobj,	\

		struct kobj_attribute *attr,				\

		char *page)						\

{									\

	return sprintf(page, _format, _value);				\

}									\

	return snprintf(page, PAGE_SIZE, _format, ##args);		\

}



#define DEFINE_IPL_ATTR_RO(_prefix, _name, _format, _value)		\

IPL_ATTR_SHOW_FN(_prefix, _name, _format, _value)			\

static struct kobj_attribute sys_##_prefix##_##_name##_attr =		\

	__ATTR(_name, S_IRUGO, sys_##_prefix##_##_name##_show, NULL);

	__ATTR(_name, S_IRUGO, sys_##_prefix##_##_name##_show, NULL)



#define DEFINE_IPL_ATTR_RW(_prefix, _name, _fmt_out, _fmt_in, _value)	\

static ssize_t sys_##_prefix##_##_name##_show(struct kobject *kobj,	\

		struct kobj_attribute *attr,				\

		char *page)						\

{									\

	return sprintf(page, _fmt_out,					\

			(unsigned long long) _value);			\

}									\

IPL_ATTR_SHOW_FN(_prefix, _name, _fmt_out, (unsigned long long) _value)	\

static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj,	\

		struct kobj_attribute *attr,				\

		const char *buf, size_t len)				\
@@ -213,15 +210,10 @@ static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj, \ 
static struct kobj_attribute sys_##_prefix##_##_name##_attr =		\

	__ATTR(_name,(S_IRUGO | S_IWUSR),				\

			sys_##_prefix##_##_name##_show,			\

			sys_##_prefix##_##_name##_store);

			sys_##_prefix##_##_name##_store)



#define DEFINE_IPL_ATTR_STR_RW(_prefix, _name, _fmt_out, _fmt_in, _value)\

static ssize_t sys_##_prefix##_##_name##_show(struct kobject *kobj,	\

		struct kobj_attribute *attr,				\

		char *page)						\

{									\

	return sprintf(page, _fmt_out, _value);				\

}									\

IPL_ATTR_SHOW_FN(_prefix, _name, _fmt_out, _value)			\

static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj,	\

		struct kobj_attribute *attr,				\

		const char *buf, size_t len)				\
@@ -233,7 +225,7 @@ static ssize_t sys_##_prefix##_##_name##_store(struct kobject *kobj, \ 
static struct kobj_attribute sys_##_prefix##_##_name##_attr =		\

	__ATTR(_name,(S_IRUGO | S_IWUSR),				\

			sys_##_prefix##_##_name##_show,			\

			sys_##_prefix##_##_name##_store);

			sys_##_prefix##_##_name##_store)



static void make_attrs_ro(struct attribute **attrs)

{