Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3bdc0f68 authored by Alexander Shishkin's avatar Alexander Shishkin Committed by Greg Kroah-Hartman
Browse files

intel_th: Fix user-visible error codes 



commit ce666be89a8a09c5924ff08fc32e119f974bdab6 upstream.

There are a few places in the driver that end up returning ENOTSUPP to
the user, replace those with EINVAL.

Signed-off-by: default avatarAlexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fixes: ba82664c ("intel_th: Add Memory Storage Unit driver")
Cc: stable@vger.kernel.org # v4.4+
Link: https://lore.kernel.org/r/20200317062215.15598-6-alexander.shishkin@linux.intel.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 97097054

drivers/hwtracing/intel_th/msu.c

+3 −3
Original line number Diff line number Diff line
@@ -761,7 +761,7 @@ static int msc_configure(struct msc *msc) 
	lockdep_assert_held(&msc->buf_mutex);



	if (msc->mode > MSC_MODE_MULTI)

		return -ENOTSUPP;

		return -EINVAL;



	if (msc->mode == MSC_MODE_MULTI) {

		if (msc_win_set_lockout(msc->cur_win, WIN_READY, WIN_INUSE))
@@ -1295,7 +1295,7 @@ static int msc_buffer_alloc(struct msc *msc, unsigned long *nr_pages, 
	} else if (msc->mode == MSC_MODE_MULTI) {

		ret = msc_buffer_multi_alloc(msc, nr_pages, nr_wins);

	} else {

		ret = -ENOTSUPP;

		ret = -EINVAL;

	}



	if (!ret) {
@@ -1531,7 +1531,7 @@ static ssize_t intel_th_msc_read(struct file *file, char __user *buf, 
		if (ret >= 0)

			*ppos = iter->offset;

	} else {

		ret = -ENOTSUPP;

		ret = -EINVAL;

	}



put_count: