Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3bd49528 authored by Nishka Dasgupta's avatar Nishka Dasgupta Committed by Herbert Xu
Browse files

crypto: nx - Add of_node_put() before return in 842 



Each iteration of for_each_compatible_node puts the previous node, but
in the case of a return from the middle of the loop, there is no put,
thus causing a memory leak. Add an of_node_put before the return.
Issue found with Coccinelle.

Acked-by: default avatarStewart Smith <stewart@linux.ibm.com>
Signed-off-by: default avatarNishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 939f146b

drivers/crypto/nx/nx-842-powernv.c

+1 −0
Original line number Diff line number Diff line
@@ -1020,6 +1020,7 @@ static __init int nx842_powernv_init(void) 
		ret = nx842_powernv_probe_vas(dn);

		if (ret) {

			nx842_delete_coprocs();

			of_node_put(dn);

			return ret;

		}

	}