Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b868a40 authored by Amit Shah's avatar Amit Shah Committed by Rusty Russell
Browse files

virtio: console: prevent use-after-free of port name in port unplug 



Remove the debugfs path before freeing port->name, to prevent a possible
use-after-free.

Reported-by: default avatarJason Wang <jasowang@redhat.com>
Signed-off-by: default avatarAmit Shah <amit.shah@redhat.com>
Signed-off-by: default avatarRusty Russell <rusty@rustcorp.com.au>
parent 11489736

drivers/char/virtio_console.c

+1 −2
Original line number Diff line number Diff line
@@ -1591,9 +1591,8 @@ static void unplug_port(struct port *port) 
	device_destroy(pdrvdata.class, port->dev->devt);

	cdev_del(port->cdev);



	kfree(port->name);



	debugfs_remove(port->debugfs_file);

	kfree(port->name);



	/*

	 * Locks around here are not necessary - a port can't be