Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b7c7e52 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Johan Hovold
Browse files

USB: serial: mos7840: fix non-atomic allocation in write path 



There is an allocation with GFP_KERNEL flag in mos7840_write(),
while it may be called from interrupt context.

Follow-up for commit 19125283 ("USB: kobil_sct: fix non-atomic
allocation in write path")

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 5a5a1d61

drivers/usb/serial/mos7840.c

+2 −2
Original line number Diff line number Diff line
@@ -1340,8 +1340,8 @@ static int mos7840_write(struct tty_struct *tty, struct usb_serial_port *port, 
	}



	if (urb->transfer_buffer == NULL) {

		urb->transfer_buffer =

		    kmalloc(URB_TRANSFER_BUFFER_SIZE, GFP_KERNEL);

		urb->transfer_buffer = kmalloc(URB_TRANSFER_BUFFER_SIZE,

					       GFP_ATOMIC);

		if (!urb->transfer_buffer)

			goto exit;

	}