Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a7ebe13 authored by Guillaume Ranquet's avatar Guillaume Ranquet Committed by Greg Kroah-Hartman
Browse files

drm/mediatek: dpi: Only enable dpi after the bridge is enabled 



[ Upstream commit aed61ef6beb911cc043af0f2f291167663995065 ]

Enabling the dpi too early causes glitches on screen.

Move the call to mtk_dpi_enable() at the end of the bridge_enable
callback to ensure everything is setup properly before enabling dpi.

Fixes: 9e629c17 ("drm/mediatek: Add DPI sub driver")
Signed-off-by: default avatarGuillaume Ranquet <granquet@baylibre.com>
Signed-off-by: default avatarBo-Chen Chen <rex-bc.chen@mediatek.com>
Tested-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/linux-mediatek/patch/20220701035845.16458-16-rex-bc.chen@mediatek.com/


Signed-off-by: default avatarChun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 42c8e38e

drivers/gpu/drm/mediatek/mtk_dpi.c

+1 −1
Original line number Diff line number Diff line
@@ -394,7 +394,6 @@ static int mtk_dpi_power_on(struct mtk_dpi *dpi) 
	if (dpi->pinctrl && dpi->pins_dpi)

		pinctrl_select_state(dpi->pinctrl, dpi->pins_dpi);



	mtk_dpi_enable(dpi);

	return 0;



err_pixel:
@@ -538,6 +537,7 @@ static void mtk_dpi_encoder_enable(struct drm_encoder *encoder) 


	mtk_dpi_power_on(dpi);

	mtk_dpi_set_display_mode(dpi, &dpi->mode);

	mtk_dpi_enable(dpi);

}



static int mtk_dpi_atomic_check(struct drm_encoder *encoder,