Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3a392b4f authored Aug 08, 2019 by Bart Van Assche Committed by Martin K. Petersen Aug 12, 2019

scsi: qla2xxx: Remove unreachable code from qla83xx_idc_lock()



This was detected by Coverity.

Cc: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Tested-by: Himanshu Madhani <hmadhani@marvell.com>
Reviewed-by: Himanshu Madhani <hmadhani@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent c29282c6

drivers/scsi/qla2xxx/qla_os.c

+0 −17

Original line number	Diff line number	Diff line
		@@ -5720,7 +5720,6 @@ qla83xx_idc_lock_recovery(scsi_qla_host_t *base_vha)
		void
		qla83xx_idc_lock(scsi_qla_host_t *base_vha, uint16_t requester_id)
		{
		uint16_t options = (requester_id << 15) \| BIT_6;
		uint32_t data;
		uint32_t lock_owner;
		struct qla_hw_data *ha = base_vha->hw;
		@@ -5753,22 +5752,6 @@ qla83xx_idc_lock(scsi_qla_host_t *base_vha, uint16_t requester_id)
		}

		return;

		/* XXX: IDC-lock implementation using access-control mbx */
		retry_lock2:
		if (qla83xx_access_control(base_vha, options, 0, 0, NULL)) {
		ql_dbg(ql_dbg_p3p, base_vha, 0xb072,
		"Failed to acquire IDC lock. retrying...\n");
		/* Retry/Perform IDC-Lock recovery */
		if (qla83xx_idc_lock_recovery(base_vha) == QLA_SUCCESS) {
		qla83xx_wait_logic();
		goto retry_lock2;
		} else
		ql_log(ql_log_warn, base_vha, 0xb076,
		"IDC Lock recovery FAILED.\n");
		}

		return;
		}

		void