Commit 3968d389 authored Jun 01, 2017 by Mintz, Yuval Committed by David S. Miller Jun 01, 2017

bnx2x: Fix Multi-Cos



Apparently multi-cos isn't working for bnx2x quite some time -
driver implements ndo_select_queue() to allow queue-selection
for FCoE, but the regular L2 flow would cause it to modulo the
fallback's result by the number of queues.
The fallback would return a queue matching the needed tc
[via __skb_tx_hash()], but since the modulo is by the number of TSS
queues where number of TCs is not accounted, transmission would always
be done by a queue configured into using TC0.

Fixes: ada7c19e ("bnx2x: use XPS if possible for bnx2x_select_queue instead of pure hash")
Signed-off-by: Yuval Mintz <Yuval.Mintz@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2b7ea64f

drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1926,7 +1926,7 @@ u16 bnx2x_select_queue(struct net_device dev, struct sk_buff skb,
		}

		/* select a non-FCoE queue */
		return fallback(dev, skb) % BNX2X_NUM_ETH_QUEUES(bp);
		return fallback(dev, skb) % (BNX2X_NUM_ETH_QUEUES(bp) * bp->max_cos);
		}

		void bnx2x_set_num_queues(struct bnx2x *bp)