Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3947b166 authored by Florian Fainelli's avatar Florian Fainelli Committed by Greg Kroah-Hartman
Browse files

irqchip/irq-brcmstb-l2: Set IRQ_LEVEL for level triggered interrupts 



[ Upstream commit 94debe03e8afa1267f95a9001786a6aa506b9ff3 ]

When support for the level triggered interrupt controller flavor was
added with c0ca7262, we forgot to update the flags to be set to
contain IRQ_LEVEL. While the flow handler is correct, the output from
/proc/interrupts does not show such interrupts as being level triggered
when they are, correct that.

Fixes: c0ca7262 ("irqchip/brcmstb-l2: Add support for the BCM7271 L2 controller")
Signed-off-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20221216230934.2478345-2-f.fainelli@gmail.com


Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent d7720900

drivers/irqchip/irq-brcmstb-l2.c

+5 −1
Original line number Diff line number Diff line
@@ -161,6 +161,7 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np, 
					  *init_params)

{

	unsigned int clr = IRQ_NOREQUEST | IRQ_NOPROBE | IRQ_NOAUTOEN;

	unsigned int set = 0;

	struct brcmstb_l2_intc_data *data;

	struct irq_chip_type *ct;

	int ret;
@@ -208,9 +209,12 @@ static int __init brcmstb_l2_intc_of_init(struct device_node *np, 
	if (IS_ENABLED(CONFIG_MIPS) && IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))

		flags |= IRQ_GC_BE_IO;



	if (init_params->handler == handle_level_irq)

		set |= IRQ_LEVEL;



	/* Allocate a single Generic IRQ chip for this node */

	ret = irq_alloc_domain_generic_chips(data->domain, 32, 1,

			np->full_name, init_params->handler, clr, 0, flags);

			np->full_name, init_params->handler, clr, set, flags);

	if (ret) {

		pr_err("failed to allocate generic irq chip\n");

		goto out_free_domain;