Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3944f139 authored by Dan Aloni's avatar Dan Aloni Committed by Herbert Xu
Browse files

crypto: fix a memory leak in rsa-kcs1pad's encryption mode 



The encryption mode of pkcs1pad never uses out_sg and out_buf, so
there's no need to allocate the buffer, which presently is not even
being freed.

CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: linux-crypto@vger.kernel.org
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: default avatarDan Aloni <dan@kernelim.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent cdf640a6

crypto/rsa-pkcs1pad.c

+0 −9
Original line number Diff line number Diff line
@@ -261,15 +261,6 @@ static int pkcs1pad_encrypt(struct akcipher_request *req) 
	pkcs1pad_sg_set_buf(req_ctx->in_sg, req_ctx->in_buf,

			ctx->key_size - 1 - req->src_len, req->src);



	req_ctx->out_buf = kmalloc(ctx->key_size, GFP_KERNEL);

	if (!req_ctx->out_buf) {

		kfree(req_ctx->in_buf);

		return -ENOMEM;

	}



	pkcs1pad_sg_set_buf(req_ctx->out_sg, req_ctx->out_buf,

			ctx->key_size, NULL);



	akcipher_request_set_tfm(&req_ctx->child_req, ctx->child);

	akcipher_request_set_callback(&req_ctx->child_req, req->base.flags,

			pkcs1pad_encrypt_sign_complete_cb, req);