Commit 38e45169 authored Oct 21, 2022 by Zhang Changzhong Committed by Greg Kroah-Hartman Nov 03, 2022

net: lantiq_etop: don't free skb when returning NETDEV_TX_BUSY



[ Upstream commit 9c1eaa27ec599fcc25ed4970c0b73c247d147a2b ]

The ndo_start_xmit() method must not free skb when returning
NETDEV_TX_BUSY, since caller is going to requeue freed skb.

Fixes: 504d4721 ("MIPS: Lantiq: Add ethernet driver")
Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 97ad240f

drivers/net/ethernet/lantiq_etop.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -466,7 +466,6 @@ ltq_etop_tx(struct sk_buff skb, struct net_device dev)
		len = skb->len < ETH_ZLEN ? ETH_ZLEN : skb->len;

		if ((desc->ctl & (LTQ_DMA_OWN \| LTQ_DMA_C)) \|\| ch->skb[ch->dma.desc]) {
		dev_kfree_skb_any(skb);
		netdev_err(dev, "tx ring full\n");
		netif_tx_stop_queue(txq);
		return NETDEV_TX_BUSY;