Commit 388f3df7 authored Jul 05, 2022 by Huaxin Lu Committed by Greg Kroah-Hartman Jul 21, 2022

ima: Fix a potential integer overflow in ima_appraise_measurement



[ Upstream commit d2ee2cfc4aa85ff6a2a3b198a3a524ec54e3d999 ]

When the ima-modsig is enabled, the rc passed to evm_verifyxattr() may be
negative, which may cause the integer overflow problem.

Fixes: 39b07096 ("ima: Implement support for module-style appended signatures")
Signed-off-by: Huaxin Lu <luhuaxin1@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 72f231b9

security/integrity/ima/ima_appraise.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -352,7 +352,8 @@ int ima_appraise_measurement(enum ima_hooks func,
		goto out;
		}

		status = evm_verifyxattr(dentry, XATTR_NAME_IMA, xattr_value, rc, iint);
		status = evm_verifyxattr(dentry, XATTR_NAME_IMA, xattr_value,
		rc < 0 ? 0 : rc, iint);
		switch (status) {
		case INTEGRITY_PASS:
		case INTEGRITY_PASS_IMMUTABLE: