Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 381c8ce0 authored by Qu Wenruo's avatar Qu Wenruo Committed by Greg Kroah-Hartman
Browse files

btrfs: prevent __btrfs_dump_space_info() to underflow its free space 



commit 0619b7901473c380abc05d45cf9c70bee0707db3 upstream.

It's not uncommon where __btrfs_dump_space_info() gets called
under over-commit situations.

In that case free space would underflow as total allocated space is not
enough to handle all the over-committed space.

Such underflow values can sometimes cause confusion for users enabled
enospc_debug mount option, and takes some seconds for developers to
convert the underflow value to signed result.

Just output the free space as s64 to avoid such problem.

Reported-by: default avatarEli V <eliventer@gmail.com>
Link: https://lore.kernel.org/linux-btrfs/CAJtFHUSy4zgyhf-4d9T+KdJp9w=UgzC2A0V=VtmaeEpcGgm1-Q@mail.gmail.com/


CC: stable@vger.kernel.org # 5.4+
Reviewed-by: default avatarAnand Jain <anand.jain@oracle.com>
Signed-off-by: default avatarQu Wenruo <wqu@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent d4ec140e

fs/btrfs/space-info.c

+3 −2
Original line number Diff line number Diff line
@@ -262,9 +262,10 @@ static void __btrfs_dump_space_info(struct btrfs_fs_info *fs_info, 
{

	lockdep_assert_held(&info->lock);



	btrfs_info(fs_info, "space_info %llu has %llu free, is %sfull",

	/* The free space could be negative in case of overcommit */

	btrfs_info(fs_info, "space_info %llu has %lld free, is %sfull",

		   info->flags,

		   info->total_bytes - btrfs_space_info_used(info, true),

		   (s64)(info->total_bytes - btrfs_space_info_used(info, true)),

		   info->full ? "" : "not ");

	btrfs_info(fs_info,

		"space_info total=%llu, used=%llu, pinned=%llu, reserved=%llu, may_use=%llu, readonly=%llu",