Commit 37e847b6 authored Aug 16, 2021 by Dan Carpenter Committed by Greg Kroah-Hartman Apr 15, 2022

iwlwifi: mvm: Fix an error code in iwl_mvm_up()



[ Upstream commit 583d18336abdfb1b355270289ff8f6a2608ba905 ]

Return -ENODEV instead of success on this error path.

Fixes: dd36a507 ("iwlwifi: mvm: look for the first supported channel when add/remove phy ctxt")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210816183930.GA2068@kili


Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 4ad7d29e

drivers/net/wireless/intel/iwlwifi/mvm/fw.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1417,8 +1417,10 @@ int iwl_mvm_up(struct iwl_mvm *mvm)
		while (!sband && i < NUM_NL80211_BANDS)
		sband = mvm->hw->wiphy->bands[i++];

		if (WARN_ON_ONCE(!sband))
		if (WARN_ON_ONCE(!sband)) {
		ret = -ENODEV;
		goto error;
		}

		chan = &sband->channels[0];