Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37c8a5fa authored by Rob Herring's avatar Rob Herring
Browse files

kbuild: consolidate Devicetree dtb build rules 



There is nothing arch specific about building dtb files other than their
location under /arch/*/boot/dts/. Keeping each arch aligned is a pain.
The dependencies and supported targets are all slightly different.
Also, a cross-compiler for each arch is needed, but really the host
compiler preprocessor is perfectly fine for building dtbs. Move the
build rules to a common location and remove the arch specific ones. This
is done in a single step to avoid warnings about overriding rules.

The build dependencies had been a mixture of 'scripts' and/or 'prepare'.
These pull in several dependencies some of which need a target compiler
(specifically devicetable-offsets.h) and aren't needed to build dtbs.
All that is really needed is dtc, so adjust the dependencies to only be
dtc.

This change enables support 'dtbs_install' on some arches which were
missing the target.

Acked-by: default avatarWill Deacon <will.deacon@arm.com>
Acked-by: default avatarPaul Burton <paul.burton@mips.com>
Acked-by: default avatarLey Foon Tan <ley.foon.tan@intel.com>
Acked-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: Vineet Gupta <vgupta@synopsys.com>
Cc: Russell King <linux@armlinux.org.uk>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Michal Simek <monstr@monstr.eu>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <jhogan@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Chris Zankel <chris@zankel.net>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-kbuild@vger.kernel.org
Cc: linux-snps-arc@lists.infradead.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: uclinux-h8-devel@lists.sourceforge.jp
Cc: linux-mips@linux-mips.org
Cc: nios2-dev@lists.rocketboards.org
Cc: linuxppc-dev@lists.ozlabs.org
Cc: linux-xtensa@linux-xtensa.org
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent be7cd2df

Makefile

+36 −1
Original line number Diff line number Diff line
@@ -1071,7 +1071,7 @@ include/config/kernel.release: $(srctree)/Makefile FORCE 
# Carefully list dependencies so we do not try to build scripts twice

# in parallel

PHONY += scripts

scripts: scripts_basic asm-generic gcc-plugins $(autoksyms_h)

scripts: scripts_basic scripts_dtc asm-generic gcc-plugins $(autoksyms_h)

	$(Q)$(MAKE) $(build)=$(@)



# Things we need to do before we recursively start building the kernel
@@ -1215,6 +1215,35 @@ kselftest-merge: 
		$(srctree)/tools/testing/selftests/*/config

	+$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig



# ---------------------------------------------------------------------------

# Devicetree files



ifneq ($(wildcard $(srctree)/arch/$(SRCARCH)/boot/dts/),)

dtstree := arch/$(SRCARCH)/boot/dts

endif



ifneq ($(dtstree),)



%.dtb: prepare3 scripts_dtc

	$(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@



PHONY += dtbs dtbs_install

dtbs: prepare3 scripts_dtc

	$(Q)$(MAKE) $(build)=$(dtstree)



dtbs_install:

	$(Q)$(MAKE) $(dtbinst)=$(dtstree)



ifdef CONFIG_OF_EARLY_FLATTREE

all: dtbs

endif



endif



PHONY += scripts_dtc

scripts_dtc: scripts_basic

	$(Q)$(MAKE) $(build)=scripts/dtc



# ---------------------------------------------------------------------------

# Modules
@@ -1424,6 +1453,12 @@ help: 
	@echo  '  kselftest-merge - Merge all the config dependencies of kselftest to existing'

	@echo  '                    .config.'

	@echo  ''

	@$(if $(dtstree), \

		echo 'Devicetree:'; \

		echo '* dtbs            - Build device tree blobs for enabled boards'; \

		echo '  dtbs_install    - Install dtbs to $(INSTALL_DTBS_PATH)'; \

		echo '')



	@echo 'Userspace tools targets:'

	@echo '  use "make tools/help"'

	@echo '  or  "cd tools; make help"'

arch/arc/Makefile

+0 −6
Original line number Diff line number Diff line
@@ -132,11 +132,5 @@ boot_targets += uImage uImage.bin uImage.gz 
$(boot_targets): vmlinux

	$(Q)$(MAKE) $(build)=$(boot) $(boot)/$@



%.dtb %.dtb.S %.dtb.o: scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@



dtbs: scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts



archclean:

	$(Q)$(MAKE) $(clean)=$(boot)

arch/arm/Makefile

+1 −19
Original line number Diff line number Diff line
@@ -307,12 +307,7 @@ else 
KBUILD_IMAGE := $(boot)/zImage

endif



# Build the DT binary blobs if we have OF configured

ifeq ($(CONFIG_USE_OF),y)

KBUILD_DTBS := dtbs

endif



all:	$(notdir $(KBUILD_IMAGE)) $(KBUILD_DTBS)

all:	$(notdir $(KBUILD_IMAGE))





archheaders:
@@ -339,17 +334,6 @@ $(BOOT_TARGETS): vmlinux 
$(INSTALL_TARGETS):

	$(Q)$(MAKE) $(build)=$(boot) MACHINE=$(MACHINE) $@



%.dtb: | scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts MACHINE=$(MACHINE) $(boot)/dts/$@



PHONY += dtbs dtbs_install



dtbs: prepare scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts



dtbs_install:

	$(Q)$(MAKE) $(dtbinst)=$(boot)/dts



PHONY += vdso_install

vdso_install:

ifeq ($(CONFIG_VDSO),y)
@@ -371,8 +355,6 @@ define archhelp 
  echo  '  uImage        - U-Boot wrapped zImage'

  echo  '  bootpImage    - Combined zImage and initial RAM disk'

  echo  '                  (supply initrd image via make variable INITRD=<path>)'

  echo  '* dtbs          - Build device tree blobs for enabled boards'

  echo  '  dtbs_install  - Install dtbs to $(INSTALL_DTBS_PATH)'

  echo  '  install       - Install uncompressed kernel'

  echo  '  zinstall      - Install compressed kernel'

  echo  '  uinstall      - Install U-Boot wrapped compressed kernel'

arch/arm64/Makefile

+1 −16
Original line number Diff line number Diff line
@@ -113,9 +113,8 @@ core-$(CONFIG_EFI_STUB) += $(objtree)/drivers/firmware/efi/libstub/lib.a 
# Default target when executing plain make

boot		:= arch/arm64/boot

KBUILD_IMAGE	:= $(boot)/Image.gz

KBUILD_DTBS	:= dtbs



all:	Image.gz $(KBUILD_DTBS)

all:	Image.gz





Image: vmlinux
@@ -127,17 +126,6 @@ Image.%: Image 
zinstall install:

	$(Q)$(MAKE) $(build)=$(boot) $@



%.dtb: scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts $(boot)/dts/$@



PHONY += dtbs dtbs_install



dtbs: prepare scripts

	$(Q)$(MAKE) $(build)=$(boot)/dts



dtbs_install:

	$(Q)$(MAKE) $(dtbinst)=$(boot)/dts



PHONY += vdso_install

vdso_install:

	$(Q)$(MAKE) $(build)=arch/arm64/kernel/vdso $@
@@ -145,7 +133,6 @@ vdso_install: 
# We use MRPROPER_FILES and CLEAN_FILES now

archclean:

	$(Q)$(MAKE) $(clean)=$(boot)

	$(Q)$(MAKE) $(clean)=$(boot)/dts



# We need to generate vdso-offsets.h before compiling certain files in kernel/.

# In order to do that, we should use the archprepare target, but we can't since
@@ -160,8 +147,6 @@ vdso_prepare: prepare0 
define archhelp

  echo  '* Image.gz      - Compressed kernel image (arch/$(ARCH)/boot/Image.gz)'

  echo  '  Image         - Uncompressed kernel image (arch/$(ARCH)/boot/Image)'

  echo  '* dtbs          - Build device tree blobs for enabled boards'

  echo  '  dtbs_install  - Install dtbs to $(INSTALL_DTBS_PATH)'

  echo  '  install       - Install uncompressed kernel'

  echo  '  zinstall      - Install compressed kernel'

  echo  '                  Install using (your) ~/bin/installkernel or'

arch/c6x/Makefile

+0 −2
Original line number Diff line number Diff line
@@ -40,9 +40,7 @@ boot := arch/$(ARCH)/boot 
DTB:=$(subst dtbImage.,,$(filter dtbImage.%, $(MAKECMDGOALS)))

export DTB



ifneq ($(DTB),)

core-y	+= $(boot)/dts/

endif



# With make 3.82 we cannot mix normal and wildcard targets