Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 378c233b authored by Xiaofei Tan's avatar Xiaofei Tan Committed by Martin K. Petersen
Browse files

scsi: hisi_sas: fix NULL check in SMP abort task path 



This patch adds a NULL check of task->lldd_task before freeing the
slot in SMP path.

This is to guard against the scenario of the slot being freed during
the from the preceding internal abort.

Signed-off-by: default avatarXiaofei Tan <tanxiaofei@huawei.com>
Signed-off-by: default avatarJohn Garry <john.garry@huawei.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 1eb8eeac

drivers/scsi/hisi_sas/hisi_sas_main.c

+1 −1
Original line number Diff line number Diff line
@@ -1161,7 +1161,7 @@ static int hisi_sas_abort_task(struct sas_task *task) 


		rc = hisi_sas_internal_task_abort(hisi_hba, device,

			     HISI_SAS_INT_ABT_CMD, tag);

		if (rc == TMF_RESP_FUNC_FAILED) {

		if (rc == TMF_RESP_FUNC_FAILED && task->lldd_task) {

			spin_lock_irqsave(&hisi_hba->lock, flags);

			hisi_sas_do_release_task(hisi_hba, task, slot);

			spin_unlock_irqrestore(&hisi_hba->lock, flags);