Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 377a80ca authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

ALSA: pcm: Test for "silence" field in struct "pcm_format_data" 

commit 2f7a26abb8241a0208c68d22815aa247c5ddacab upstream.

Syzbot reports "KASAN: null-ptr-deref Write in
snd_pcm_format_set_silence".[1]

It is due to missing validation of the "silence" field of struct
"pcm_format_data" in "pcm_formats" array.

Add a test for valid "pat" and, if it is not so, return -EINVAL.

[1] https://lore.kernel.org/lkml/000000000000d188ef05dc2c7279@google.com/



Reported-and-tested-by: default avatar <syzbot+205eb15961852c2c5974@syzkaller.appspotmail.com>
Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220409012655.9399-1-fmdefrancesco@gmail.com


Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5f77b1c0

sound/core/pcm_misc.c

+1 −1
Original line number Diff line number Diff line
@@ -423,7 +423,7 @@ int snd_pcm_format_set_silence(snd_pcm_format_t format, void *data, unsigned int 
		return 0;

	width = pcm_formats[(INT)format].phys; /* physical width */

	pat = pcm_formats[(INT)format].silence;

	if (! width)

	if (!width || !pat)

		return -EINVAL;

	/* signed or 1 byte data */

	if (pcm_formats[(INT)format].signd == 1 || width <= 8) {