Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 37480a59 authored by Harshit Mogalapalli's avatar Harshit Mogalapalli Committed by Greg Kroah-Hartman
Browse files

usb: yurex: Fix inconsistent locking bug in yurex_read() 



commit e7d3b9f28654dbfce7e09f8028210489adaf6a33 upstream.

Unlock before returning on the error path.

Fixes: 86b20af11e84 ("usb: yurex: Replace snprintf() with the safer scnprintf() variant")
Reported-by: default avatarDan Carpenter <error27@gmail.com>
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/r/202312170252.3udgrIcP-lkp@intel.com/


Signed-off-by: default avatarHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://lore.kernel.org/r/20231219063639.450994-1-harshit.m.mogalapalli@oracle.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 031533b6

drivers/usb/misc/yurex.c

+3 −1
Original line number Diff line number Diff line
@@ -414,8 +414,10 @@ static ssize_t yurex_read(struct file *file, char __user *buffer, size_t count, 
		return -ENODEV;

	}



	if (WARN_ON_ONCE(dev->bbu > S64_MAX || dev->bbu < S64_MIN))

	if (WARN_ON_ONCE(dev->bbu > S64_MAX || dev->bbu < S64_MIN)) {

		mutex_unlock(&dev->io_mutex);

		return -EIO;

	}



	spin_lock_irq(&dev->lock);

	scnprintf(in_buffer, MAX_S64_STRLEN, "%lld\n", dev->bbu);