Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3725369f authored by Colin Ian King's avatar Colin Ian King Committed by Bartlomiej Zolnierkiewicz
Browse files

video: fbdev: intelfb: remove redundant variables 



Variables err_max, err_target and f_best are being assigned values but
these are never read, hence they are redundant variables and can be
removed. Cleans up clang warnings:

drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to
'err_max' is never read
drivers/video/fbdev/intelfb/intelfbhw.c:947:2: warning: Value stored to
'err_target' is never read
drivers/video/fbdev/intelfb/intelfbhw.c:995:6: warning: Value stored to
'f_best' is never read

Signed-off-by: default avatarColin Ian King <colin.king@canonical.com>
Cc: Maik Broemme <mbroemme@libmpq.org>
Signed-off-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
parent 6b04e9f2

drivers/video/fbdev/intelfb/intelfbhw.c

+2 −7
Original line number Original line Diff line number Diff line
@@ -937,15 +937,11 @@ static int calc_pll_params(int index, int clock, u32 *retm1, u32 *retm2, 
{

{

	u32 m1, m2, n, p1, p2, n1, testm;

	u32 m1, m2, n, p1, p2, n1, testm;

	u32 f_vco, p, p_best = 0, m, f_out = 0;

	u32 f_vco, p, p_best = 0, m, f_out = 0;

	u32 err_max, err_target, err_best = 10000000;

	u32 err_best = 10000000;

	u32 n_best = 0, m_best = 0, f_best, f_err;

	u32 n_best = 0, m_best = 0, f_err;

	u32 p_min, p_max, p_inc, div_max;

	u32 p_min, p_max, p_inc, div_max;

	struct pll_min_max *pll = &plls[index];

	struct pll_min_max *pll = &plls[index];





	/* Accept 0.5% difference, but aim for 0.1% */

	err_max = 5 * clock / 1000;

	err_target = clock / 1000;



	DBG_MSG("Clock is %d\n", clock);

	DBG_MSG("Clock is %d\n", clock);





	div_max = pll->max_vco / clock;

	div_max = pll->max_vco / clock;
@@ -992,7 +988,6 @@ static int calc_pll_params(int index, int clock, u32 *retm1, u32 *retm2, 
					m_best = testm;

					m_best = testm;

					n_best = n;

					n_best = n;

					p_best = p;

					p_best = p;

					f_best = f_out;

					err_best = f_err;

					err_best = f_err;

				}

				}

			}

			}