Commit 36fed498 authored Jun 21, 2012 by Maciej Trela Committed by James Bottomley Jul 20, 2012

[SCSI] libsas: cleanup spurious calls to scsi_schedule_eh



eh is woken up automatically by the presence of failed commands,
scsi_schedule_eh is reserved for cases where there are no failed
commands.  This guarantees that host_eh_sceduled is only incremented
when an explicit eh request is made.

Reviewed-by: Jacek Danecki <jacek.danecki@intel.com>
Signed-off-by: Maciej Trela <maciej.trela@intel.com>
[fixed spurious delete of sas_ata_task_abort]
Signed-off-by: Artur Wojcik <artur.wojcik@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 57fc2e33

drivers/scsi/libsas/sas_ata.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -618,7 +618,6 @@ void sas_ata_task_abort(struct sas_task *task)
		spin_lock_irqsave(q->queue_lock, flags);
		blk_abort_request(qc->scsicmd->request);
		spin_unlock_irqrestore(q->queue_lock, flags);
		scsi_schedule_eh(qc->scsicmd->device->host);
		return;
		}

drivers/scsi/libsas/sas_scsi_host.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1018,7 +1018,6 @@ void sas_task_abort(struct sas_task *task)
		spin_lock_irqsave(q->queue_lock, flags);
		blk_abort_request(sc->request);
		spin_unlock_irqrestore(q->queue_lock, flags);
		scsi_schedule_eh(sc->device->host);
		}
		}