Commit 36ce931a authored Mar 18, 2021 by Lee Jones Committed by Greg Kroah-Hartman Dec 13, 2023

of: base: Fix some formatting issues and provide missing descriptions

[ Upstream commit 3637d49e11219512920aca8b8ccd0994be33fa8b ]

Fixes the following W=1 kernel build warning(s):

drivers/of/base.c:315: warning: Function parameter or member 'cpun' not described in '__of_find_n_match_cpu_property'
drivers/of/base.c:315: warning: Function parameter or member 'prop_name' not described in '__of_find_n_match_cpu_property'
drivers/of/base.c:315: warning: Function parameter or member 'cpu' not described in '__of_find_n_match_cpu_property'
drivers/of/base.c:315: warning: Function parameter or member 'thread' not described in '__of_find_n_match_cpu_property'
drivers/of/base.c:315: warning: expecting prototype for property holds the physical id of the(). Prototype was for __of_find_n_match_cpu_property() instead
drivers/of/base.c:1139: warning: Function parameter or member 'match' not described in 'of_find_matching_node_and_match'
drivers/of/base.c:1779: warning: Function parameter or member 'np' not described in '__of_add_property'
drivers/of/base.c:1779: warning: Function parameter or member 'prop' not described in '__of_add_property'
drivers/of/base.c:1800: warning: Function parameter or member 'np' not described in 'of_add_property'
drivers/of/base.c:1800: warning: Function parameter or member 'prop' not described in 'of_add_property'
drivers/of/base.c:1849: warning: Function parameter or member 'np' not described in 'of_remove_property'
drivers/of/base.c:1849: warning: Function parameter or member 'prop' not described in 'of_remove_property'
drivers/of/base.c:2137: warning: Function parameter or member 'dn' not described in 'of_console_check'
drivers/of/base.c:2137: warning: Function parameter or member 'name' not described in 'of_console_check'
drivers/of/base.c:2137: warning: Function parameter or member 'index' not described in 'of_console_check'

Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: devicetree@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20210318104036.3175910-5-lee.jones@linaro.org

Stable-dep-of: d79972789d17 ("of: dynamic: Fix of_reconfig_get_state_change() return value documentation")
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 8c4fcbe2

drivers/of/base.c

+11 −5

Original line number	Diff line number	Diff line
		@@ -367,7 +367,7 @@ bool __weak arch_match_cpu_phys_id(int cpu, u64 phys_id)
		return (u32)phys_id == cpu;
		}

		/**
		/*
		* Checks if the given "prop_name" property holds the physical id of the
		* core/thread corresponding to the logical cpu 'cpu'. If 'thread' is not
		* NULL, local thread number within the core is returned in it.
		@@ -1190,7 +1190,7 @@ EXPORT_SYMBOL(of_match_node);
		* will; typically, you pass what the previous call
		* returned. of_node_put() will be called on it
		* @matches: array of of device match structures to search in
		* @match Updated to point at the matches entry which matched
		* @match: Updated to point at the matches entry which matched
		*
		* Returns a node pointer with refcount incremented, use
		* of_node_put() on it when done.
		@@ -1853,6 +1853,8 @@ EXPORT_SYMBOL(of_count_phandle_with_args);

		/**
		* __of_add_property - Add a property to a node without lock operations
		* @np: Caller's Device Node
		* @prob: Property to add
		*/
		int __of_add_property(struct device_node np, struct property prop)
		{
		@@ -1874,6 +1876,8 @@ int __of_add_property(struct device_node np, struct property prop)

		/**
		* of_add_property - Add a property to a node
		* @np: Caller's Device Node
		* @prob: Property to add
		*/
		int of_add_property(struct device_node np, struct property prop)
		{
		@@ -1918,6 +1922,8 @@ int __of_remove_property(struct device_node np, struct property prop)

		/**
		* of_remove_property - Remove a property from a node.
		* @np: Caller's Device Node
		* @prob: Property to remove
		*
		* Note that we don't actually remove it, since we have given out
		* who-knows-how-many pointers to the data using get-property.
		@@ -2203,9 +2209,9 @@ EXPORT_SYMBOL_GPL(of_alias_get_highest_id);

		/**
		* of_console_check() - Test and setup console for DT setup
		* @dn - Pointer to device node
		* @name - Name to use for preferred console without index. ex. "ttyS"
		* @index - Index to use for preferred console.
		* @dn: Pointer to device node
		* @name: Name to use for preferred console without index. ex. "ttyS"
		* @index: Index to use for preferred console.
		*
		* Check if the given device node matches the stdout-path property in the
		* /chosen node. If it does then register it as the preferred console and return