Commit 36c95494 authored Mar 14, 2014 by James Hogan Committed by Paolo Bonzini Mar 19, 2014

MIPS: KVM: Remove dead code in CP0 emulation

The code to check whether rd > MIPS_CP0_DESAVE is dead code, since
MIPS_CP0_DESAVE = 31 and rd is already masked with 0x1f. Remove it.

Signed-off-by: James Hogan <james.hogan@imgtec.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Gleb Natapov <gleb@kernel.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Sanjay Lal <sanjayl@kymasys.com>
Cc: linux-mips@linux-mips.org
Cc: kvm@vger.kernel.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 26f4f3b5

arch/mips/kvm/kvm_mips_emul.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -436,13 +436,6 @@ kvm_mips_emulate_CP0(uint32_t inst, uint32_t *opc, uint32_t cause,
		sel = inst & 0x7;
		co_bit = (inst >> 25) & 1;

		/* Verify that the register is valid */
		if (rd > MIPS_CP0_DESAVE) {
		printk("Invalid rd: %d\n", rd);
		er = EMULATE_FAIL;
		goto done;
		}

		if (co_bit) {
		op = (inst) & 0xff;