Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36b51146 authored by Roberto Alcântara's avatar Roberto Alcântara Committed by Mauro Carvalho Chehab
Browse files

[media] smscoreapi: memory leak fix 



Ensure release_firmware is called if kmalloc fails.

[mchehab@redhat.com: patch unmangled and converted from -p2 to -p1]
Signed-off-by: default avatarRoberto Alcantara <roberto@eletronica.org>

Signed-off-by: default avatarMauro Carvalho Chehab <mchehab@redhat.com>
parent 62d54876

drivers/media/common/siano/smscoreapi.c

+9 −8
Original line number Diff line number Diff line
@@ -1173,8 +1173,8 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev, 
			 GFP_KERNEL | GFP_DMA);

	if (!fw_buf) {

		sms_err("failed to allocate firmware buffer");

		return -ENOMEM;

	}

		rc = -ENOMEM;

	} else {

		memcpy(fw_buf, fw->data, fw->size);

		fw_buf_size = fw->size;
@@ -1182,6 +1182,7 @@ static int smscore_load_firmware_from_file(struct smscore_device_t *coredev, 
			smscore_load_firmware_family2(coredev, fw_buf, fw_buf_size)

			: loadfirmware_handler(coredev->context, fw_buf,

			fw_buf_size);

	}



	kfree(fw_buf);

	release_firmware(fw);