Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 367c359a authored by Jernej Skrabec's avatar Jernej Skrabec Committed by Maxime Ripard
Browse files

drm/sun4i: Fix releasing node when enumerating enpoints 



sun4i_drv_add_endpoints() has a memory leak since it uses of_node_put()
when remote is equal to NULL and does nothing when remote has a valid
pointer.

Invert the logic to fix memory leak.

Signed-off-by: default avatarJernej Skrabec <jernej.skrabec@siol.net>
Signed-off-by: default avatarMaxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180625120304.7543-7-jernej.skrabec@siol.net
parent 19f3ebed

drivers/gpu/drm/sun4i/sun4i_drv.c

+2 −1
Original line number Diff line number Diff line
@@ -283,7 +283,6 @@ static int sun4i_drv_add_endpoints(struct device *dev, 
		remote = of_graph_get_remote_port_parent(ep);

		if (!remote) {

			DRM_DEBUG_DRIVER("Error retrieving the output node\n");

			of_node_put(remote);

			continue;

		}
@@ -297,11 +296,13 @@ static int sun4i_drv_add_endpoints(struct device *dev, 


			if (of_graph_parse_endpoint(ep, &endpoint)) {

				DRM_DEBUG_DRIVER("Couldn't parse endpoint\n");

				of_node_put(remote);

				continue;

			}



			if (!endpoint.id) {

				DRM_DEBUG_DRIVER("Endpoint is our panel... skipping\n");

				of_node_put(remote);

				continue;

			}

		}