Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 36415615 authored by Jordan Crouse's avatar Jordan Crouse Committed by Rob Clark
Browse files

drm/msm/dpu: Fix error recovery after failing to enable clocks 



If enabling clocks fails in msm_dss_enable_clk() the code to unwind the
settings starts at 'i' which is the clock that just failed. While this
isn't harmful it does result in a number of warnings from the clock
subsystem while trying to unpreare/disable the very clock that had
just failed to prepare/enable. Skip the current failed clock during
the unwind to to avoid the extra log spew.

Signed-off-by: default avatarJordan Crouse <jcrouse@codeaurora.org>
Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
parent 295b22ae

drivers/gpu/drm/msm/disp/dpu1/dpu_io_util.c

+3 −3
Original line number Diff line number Diff line
@@ -114,9 +114,9 @@ int msm_dss_enable_clk(struct dss_clk *clk_arry, int num_clk, int enable) 
				rc = -EPERM;

			}



			if (rc) {

				msm_dss_enable_clk(&clk_arry[i],

					i, false);

			if (rc && i) {

				msm_dss_enable_clk(&clk_arry[i - 1],

					i - 1, false);

				break;

			}

		}