Commit 35f61d7b authored Jan 06, 2019 by Geert Uytterhoeven

m68k: Avoid VLA use in mangle_kernel_stack()



With gcc 7.3.0:

    arch/m68k/kernel/signal.c: In function ‘mangle_kernel_stack’:
    arch/m68k/kernel/signal.c:654:3: warning: ISO C90 forbids variable length array ‘buf’ [-Wvla]
       unsigned long buf[fsize / 2]; /* yes, twice as much */
       ^~~~~~~~

Replace the variable size by the upper limit, which is 168 bytes.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Arnd Bergmann <arnd@arndb.de>

parent 9c0e91f6

arch/m68k/kernel/signal.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -651,7 +651,8 @@ static int mangle_kernel_stack(struct pt_regs *regs, int formatvec,
		regs->vector = formatvec & 0xfff;
		} else {
		struct switch_stack sw = (struct switch_stack )regs - 1;
		unsigned long buf[fsize / 2]; /* yes, twice as much */
		/* yes, twice as much as max(sizeof(frame.un.fmt<x>)) */
		unsigned long buf[sizeof(((struct frame *)0)->un) / 2];

		/* that'll make sure that expansion won't crap over data */
		if (copy_from_user(buf + fsize / 4, fp, fsize))