Commit 35b50e70 authored Apr 03, 2019 by Gustavo A. R. Silva Committed by Kalle Valo May 07, 2019

ath10k: Use struct_size() helper



Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes, in particular in the
context in which this code is being used.

So, change the following form:

sizeof(*rx) + (sizeof(struct htt_rx_indication_mpdu_range) * num_mpdu_ranges)

 to :

struct_size(rx, mpdu_ranges, num_mpdu_ranges)

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 42f1bc43

drivers/net/wireless/ath/ath10k/htt_rx.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -2509,9 +2509,7 @@ static void ath10k_htt_rx_proc_rx_ind_ll(struct ath10k_htt *htt,
		mpdu_ranges = htt_rx_ind_get_mpdu_ranges(rx);

		ath10k_dbg_dump(ar, ATH10K_DBG_HTT_DUMP, NULL, "htt rx ind: ",
		rx, sizeof(*rx) +
		(sizeof(struct htt_rx_indication_mpdu_range) *
		num_mpdu_ranges));
		rx, struct_size(rx, mpdu_ranges, num_mpdu_ranges));

		for (i = 0; i < num_mpdu_ranges; i++)
		mpdu_count += mpdu_ranges[i].mpdu_count;