Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 35acfbab authored Feb 22, 2019 by Li RongQing Committed by Pablo Neira Ayuso Feb 27, 2019

netfilter: remove unneeded switch fall-through



Empty case is fine and does not switch fall-through

Signed-off-by: Li RongQing <lirongqing@baidu.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

parent cc169213

net/netfilter/nf_nat_core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -240,7 +240,7 @@ static bool l4proto_in_range(const struct nf_conntrack_tuple *tuple,
		__be16 port;

		switch (tuple->dst.protonum) {
		case IPPROTO_ICMP: /* fallthrough */
		case IPPROTO_ICMP:
		case IPPROTO_ICMPV6:
		return ntohs(tuple->src.u.icmp.id) >= ntohs(min->icmp.id) &&
		ntohs(tuple->src.u.icmp.id) <= ntohs(max->icmp.id);

net/netfilter/nf_tables_core.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -221,7 +221,6 @@ nft_do_chain(struct nft_pktinfo pkt, void priv)
		chain = regs.verdict.chain;
		goto do_chain;
		case NFT_CONTINUE:
		/* fall through */
		case NFT_RETURN:
		nft_trace_packet(&info, chain, rule,
		NFT_TRACETYPE_RETURN);