Commit 355200e0 authored May 20, 2019 by Adrian Hunter Committed by Arnaldo Carvalho de Melo May 28, 2019

perf auxtrace: Fix itrace defaults for perf script



Commit 4eb06815 ("perf script: Make itrace script default to all
calls") does not work for the case when '--itrace' only is used, because
default_no_sample is not being passed.

Example:

 Before:

  $ perf record -e intel_pt/cyc/u ls
  $ perf script --itrace > cmp1.txt
  $ perf script --itrace=cepwx > cmp2.txt
  $ diff -sq cmp1.txt cmp2.txt
  Files cmp1.txt and cmp2.txt differ

 After:

  $ perf script --itrace > cmp1.txt
  $ perf script --itrace=cepwx > cmp2.txt
  $ diff -sq cmp1.txt cmp2.txt
  Files cmp1.txt and cmp2.txt are identical

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: stable@vger.kernel.org
Fixes: 4eb06815 ("perf script: Make itrace script default to all calls")
Link: http://lkml.kernel.org/r/20190520113728.14389-3-adrian.hunter@intel.com


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 26f19c2e

tools/perf/util/auxtrace.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -1010,7 +1010,8 @@ int itrace_parse_synth_opts(const struct option opt, const char str,
		}

		if (!str) {
		itrace_synth_opts__set_default(synth_opts, false);
		itrace_synth_opts__set_default(synth_opts,
		synth_opts->default_no_sample);
		return 0;
		}