Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 354d7793 authored by Peter Zijlstra's avatar Peter Zijlstra Committed by Ingo Molnar
Browse files

sched/autogroup: Fix possible Spectre-v1 indexing for sched_prio_to_weight[] 



> kernel/sched/autogroup.c:230 proc_sched_autogroup_set_nice() warn: potential spectre issue 'sched_prio_to_weight'

Userspace controls @nice, sanitize the array index.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@kernel.org>
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 7281c8de

kernel/sched/autogroup.c

+5 −2
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
/*

 * Auto-group scheduling implementation:

 */

#include <linux/nospec.h>

#include "sched.h"



unsigned int __read_mostly sysctl_sched_autogroup_enabled = 1;
@@ -209,7 +210,7 @@ int proc_sched_autogroup_set_nice(struct task_struct *p, int nice) 
	static unsigned long next = INITIAL_JIFFIES;

	struct autogroup *ag;

	unsigned long shares;

	int err;

	int err, idx;



	if (nice < MIN_NICE || nice > MAX_NICE)

		return -EINVAL;
@@ -227,7 +228,9 @@ int proc_sched_autogroup_set_nice(struct task_struct *p, int nice) 


	next = HZ / 10 + jiffies;

	ag = autogroup_task_get(p);

	shares = scale_load(sched_prio_to_weight[nice + 20]);



	idx = array_index_nospec(nice + 20, 40);

	shares = scale_load(sched_prio_to_weight[idx]);



	down_write(&ag->lock);

	err = sched_group_set_shares(ag->tg, shares);