Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3517dfe6 authored by Maxim Mikityanskiy's avatar Maxim Mikityanskiy Committed by David S. Miller
Browse files

net/mlx5e: Remove the wrong assumption about transport offset 



skb_transport_offset() == 0 is not a special value. The only special
value is when skb->transport_header is ~0U, and it's checked by
skb_transport_header_was_set().

Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@mellanox.com>
Reviewed-by: default avatarSaeed Mahameed <saeedm@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 6437866e

drivers/net/ethernet/mellanox/mlx5/core/en_tx.c

+2 −9
Original line number Diff line number Diff line
@@ -172,15 +172,8 @@ static inline u16 mlx5e_calc_min_inline(enum mlx5_inline_modes mode, 
			hlen += VLAN_HLEN;

		break;

	case MLX5_INLINE_MODE_IP:

		/* When transport header is set to zero, it means no transport

		 * header. When transport header is set to 0xff's, it means

		 * transport header wasn't set.

		 */

		if (skb_transport_offset(skb)) {

		hlen = mlx5e_skb_l3_header_offset(skb);

		break;

		}

		/* fall through */

	case MLX5_INLINE_MODE_L2:

	default:

		hlen = mlx5e_skb_l2_header_offset(skb);