Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34f81f04 authored by Huazhong Tan's avatar Huazhong Tan Committed by David S. Miller
Browse files

net: hns3: clear command queue's registers when unloading VF driver 



According to the hardware's description, the driver should clear
the command queue's registers when uloading VF driver. Otherwise,
these existing value may lead the IMP get into a wrong state.

Fixes: fedd0c15 ("net: hns3: Add HNS3 VF IMP(Integrated Management Proc) cmd interface")
Signed-off-by: default avatarHuazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: default avatarPeng Li <lipeng321@huawei.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 232d0d55

drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c

+20 −0
Original line number Diff line number Diff line
@@ -362,8 +362,28 @@ int hclgevf_cmd_init(struct hclgevf_dev *hdev) 
	return 0;

}



static void hclgevf_cmd_uninit_regs(struct hclgevf_hw *hw)

{

	hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_BASEADDR_L_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_BASEADDR_H_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_DEPTH_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_HEAD_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CSQ_TAIL_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_BASEADDR_L_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_BASEADDR_H_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_DEPTH_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_HEAD_REG, 0);

	hclgevf_write_dev(hw, HCLGEVF_NIC_CRQ_TAIL_REG, 0);

}



void hclgevf_cmd_uninit(struct hclgevf_dev *hdev)

{

	spin_lock_bh(&hdev->hw.cmq.csq.lock);

	spin_lock(&hdev->hw.cmq.crq.lock);

	clear_bit(HCLGEVF_STATE_CMD_DISABLE, &hdev->state);

	hclgevf_cmd_uninit_regs(&hdev->hw);

	spin_unlock(&hdev->hw.cmq.crq.lock);

	spin_unlock_bh(&hdev->hw.cmq.csq.lock);

	hclgevf_free_cmd_desc(&hdev->hw.cmq.csq);

	hclgevf_free_cmd_desc(&hdev->hw.cmq.crq);

}