Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34c5c01e authored by Miquel Raynal's avatar Miquel Raynal Committed by Boris Brezillon
Browse files

mtd: rawnand: macronix: nack the support of changing timings for one chip 



The MX30LF2G18AC chip declares in its parameter page supporting
SET/GET_FEATURES but when it comes to timings, experience shows that it
is not the case.

Unflag this feature for this particular chip in the nand_parameters
structure to avoid unnecessary errors and downturns.

Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarBoris Brezillon <boris.brezillon@bootlin.com>
parent 789157e4

drivers/mtd/nand/raw/nand_macronix.c

+13 −0
Original line number Diff line number Diff line
@@ -22,6 +22,19 @@ static int macronix_nand_init(struct nand_chip *chip) 
	if (nand_is_slc(chip))

		chip->bbt_options |= NAND_BBT_SCAN2NDPAGE;



	/*

	 * MX30LF2G18AC chip does not support using SET/GET_FEATURES to change

	 * the timings unlike what is declared in the parameter page. Unflag

	 * this feature to avoid unnecessary downturns.

	 */

	if (chip->parameters.supports_set_get_features &&

	    !strcmp("MX30LF2G18AC", chip->parameters.model)) {

		bitmap_clear(chip->parameters.get_feature_list,

			     ONFI_FEATURE_ADDR_TIMING_MODE, 1);

		bitmap_clear(chip->parameters.set_feature_list,

			     ONFI_FEATURE_ADDR_TIMING_MODE, 1);

	}



	return 0;

}