Commit 34a47f7d authored Mar 19, 2022 by Christophe JAILLET Committed by Greg Kroah-Hartman Apr 15, 2022

scsi: zorro7xx: Fix a resource leak in zorro7xx_remove_one()

[ Upstream commit 16ed828b872d12ccba8f07bcc446ae89ba662f9c ]

The error handling path of the probe releases a resource that is not freed
in the remove function. In some cases, a ioremap() must be undone.

Add the missing iounmap() call in the remove function.

Link: https://lore.kernel.org/r/247066a3104d25f9a05de8b3270fc3c848763bcc.1647673264.git.christophe.jaillet@wanadoo.fr


Fixes: 45804fbb ("[SCSI] 53c700: Amiga Zorro NCR53c710 SCSI")
Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent 2133c422

drivers/scsi/zorro7xx.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -159,6 +159,8 @@ static void zorro7xx_remove_one(struct zorro_dev *z)
		scsi_remove_host(host);

		NCR_700_release(host);
		if (host->base > 0x01000000)
		iounmap(hostdata->base);
		kfree(hostdata);
		free_irq(host->irq, host);
		zorro_release_device(z);