Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3451944a authored by Krishna Kurapati's avatar Krishna Kurapati Committed by Greg Kroah-Hartman
Browse files

usb: dwc3: qcom: Don't leave BCR asserted 



commit ef8abc0ba49ce717e6bc4124e88e59982671f3b5 upstream.

Leaving the USB BCR asserted prevents the associated GDSC to turn on. This
blocks any subsequent attempts of probing the device, e.g. after a probe
deferral, with the following showing in the log:

[    1.332226] usb30_prim_gdsc status stuck at 'off'

Leave the BCR deasserted when exiting the driver to avoid this issue.

Cc: stable <stable@kernel.org>
Fixes: a4333c3a ("usb: dwc3: Add Qualcomm DWC3 glue driver")
Acked-by: default avatarThinh Nguyen <Thinh.Nguyen@synopsys.com>
Reviewed-by: default avatarKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Signed-off-by: default avatarKrishna Kurapati <krishna.kurapati@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250709132900.3408752-1-krishna.kurapati@oss.qualcomm.com


[ adapted to individual clock management API instead of bulk clock operations ]
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 4ea93e0e

drivers/usb/dwc3/dwc3-qcom.c

+2 −6
Original line number Diff line number Diff line
@@ -615,13 +615,13 @@ static int dwc3_qcom_probe(struct platform_device *pdev) 
	ret = reset_control_deassert(qcom->resets);

	if (ret) {

		dev_err(&pdev->dev, "failed to deassert resets, err=%d\n", ret);

		goto reset_assert;

		return ret;

	}



	ret = dwc3_qcom_clk_init(qcom, of_clk_get_parent_count(np));

	if (ret) {

		dev_err(dev, "failed to get clocks\n");

		goto reset_assert;

		return ret;

	}



	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
@@ -700,8 +700,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev) 
		clk_disable_unprepare(qcom->clks[i]);

		clk_put(qcom->clks[i]);

	}

reset_assert:

	reset_control_assert(qcom->resets);



	return ret;

}
@@ -725,8 +723,6 @@ static int dwc3_qcom_remove(struct platform_device *pdev) 
	}

	qcom->num_clocks = 0;



	reset_control_assert(qcom->resets);



	pm_runtime_allow(dev);

	pm_runtime_disable(dev);