Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3427beb6 authored by David Howells's avatar David Howells Committed by David S. Miller
Browse files

rxrpc: Fix uninitialized error code in rxrpc_send_data_packet()



With gcc 4.1:

    net/rxrpc/output.c: In function ‘rxrpc_send_data_packet’:
    net/rxrpc/output.c:338: warning: ‘ret’ may be used uninitialized in this function

Indeed, if the first jump to the send_fragmentable label is made, and
the address family is not handled in the switch() statement, ret will be
used uninitialized.

Fix this by BUG()'ing as is done in other places in rxrpc where internal
support for future address families will need adding.  It should not be
possible to reach this normally as the address families are checked
up-front.

Fixes: 5a924b89 ("rxrpc: Don't store the rxrpc header in the Tx queue sk_buffs")
Reported-by: default avatarGeert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 23ec8eaf
Loading
Loading
Loading
Loading
+3 −0
Original line number Diff line number Diff line
@@ -519,6 +519,9 @@ int rxrpc_send_data_packet(struct rxrpc_call *call, struct sk_buff *skb,
		}
		break;
#endif

	default:
		BUG();
	}

	if (ret < 0)