Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 340f25ff authored by Fuqian Huang's avatar Fuqian Huang Committed by Andy Shevchenko
Browse files

platform/x86: asus-wmi: Use kmemdup rather than duplicating its implementation 



kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.

Signed-off-by: default avatarFuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
parent 4215484f

drivers/platform/x86/asus-wmi.c

+1 −2
Original line number Diff line number Diff line
@@ -292,12 +292,11 @@ static int asus_wmi_evaluate_method_agfn(const struct acpi_buffer args) 
	 * Copy to dma capable address otherwise memory corruption occurs as

	 * bios has to be able to access it.

	 */

	input.pointer = kzalloc(args.length, GFP_DMA | GFP_KERNEL);

	input.pointer = kmemdup(args.pointer, args.length, GFP_DMA | GFP_KERNEL);

	input.length = args.length;

	if (!input.pointer)

		return -ENOMEM;

	phys_addr = virt_to_phys(input.pointer);

	memcpy(input.pointer, args.pointer, args.length);



	status = asus_wmi_evaluate_method(ASUS_WMI_METHODID_AGFN,

					phys_addr, 0, &retval);