Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 339ba693 authored by Yang Yingliang's avatar Yang Yingliang Committed by Greg Kroah-Hartman
Browse files

regulator: core: fix module refcount leak in set_supply() 



[ Upstream commit da46ee19cbd8344d6860816b4827a7ce95764867 ]

If create_regulator() fails in set_supply(), the module refcount
needs be put to keep refcount balanced.

Fixes: e2c09ae7 ("regulator: core: Increase refcount for regulator supply's module")
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221201122706.4055992-2-yangyingliang@huawei.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent 46dfff91

drivers/regulator/core.c

+1 −0
Original line number Diff line number Diff line
@@ -1431,6 +1431,7 @@ static int set_supply(struct regulator_dev *rdev, 


	rdev->supply = create_regulator(supply_rdev, &rdev->dev, "SUPPLY");

	if (rdev->supply == NULL) {

		module_put(supply_rdev->owner);

		err = -ENOMEM;

		return err;

	}