Commit 3359f8d5 authored Nov 25, 2022 by ZhangPeng Committed by Greg Kroah-Hartman Jan 18, 2023

pinctrl: pinconf-generic: add missing of_node_put()



[ Upstream commit 5ead93289815a075d43c415e35c8beafafb801c9 ]

of_node_put() needs to be called when jumping out of the loop, since
for_each_available_child_of_node() will increase the refcount of node.

Fixes: c7289500 ("pinctrl: pinconf-generic: scan also referenced phandle node")
Signed-off-by: ZhangPeng <zhangpeng362@huawei.com>
Link: https://lore.kernel.org/r/20221125070156.3535855-1-zhangpeng362@huawei.com


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

parent ffd53b78

drivers/pinctrl/pinconf-generic.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -391,9 +391,11 @@ int pinconf_generic_dt_node_to_map(struct pinctrl_dev *pctldev,
		for_each_available_child_of_node(np_config, np) {
		ret = pinconf_generic_dt_subnode_to_map(pctldev, np, map,
		&reserved_maps, num_maps, type);
		if (ret < 0)
		if (ret < 0) {
		of_node_put(np);
		goto exit;
		}
		}
		return 0;

		exit: