Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 3356d9f4 authored by Alexey Khoroshilov's avatar Alexey Khoroshilov Committed by Mark Brown
Browse files

spi: pic32-sqi: remove unnecessary of_node_get() 



Almost all spi drivers assign spi master->dev.of_node from
its parent platform device without additional refcounting.
It seems of_node_get() in pic32_sqi_probe() is unnecessary
and there is no corresponding of_node_put().

Found by Linux Driver Verification project (linuxtesting.org)

Signed-off-by: default avatarAlexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 37a1aa88

drivers/spi/spi-pic32-sqi.c

+1 −1
Original line number Diff line number Diff line
@@ -656,7 +656,7 @@ static int pic32_sqi_probe(struct platform_device *pdev) 
	master->max_speed_hz	= clk_get_rate(sqi->base_clk);

	master->dma_alignment	= 32;

	master->max_dma_len	= PESQI_BD_BUF_LEN_MAX;

	master->dev.of_node	= of_node_get(pdev->dev.of_node);

	master->dev.of_node	= pdev->dev.of_node;

	master->mode_bits	= SPI_MODE_3 | SPI_MODE_0 | SPI_TX_DUAL |

				  SPI_RX_DUAL | SPI_TX_QUAD | SPI_RX_QUAD;

	master->flags		= SPI_MASTER_HALF_DUPLEX;