Commit 333a2a98 authored Feb 22, 2023 by Randy Dunlap Committed by Greg Kroah-Hartman May 17, 2023

macintosh: via-pmu-led: requires ATA to be set



[ Upstream commit 05dce4ba125336875cd3eed3c1503fa81cd2f691 ]

LEDS_TRIGGER_DISK depends on ATA, so selecting LEDS_TRIGGER_DISK
when ATA is not set/enabled causes a Kconfig warning:

WARNING: unmet direct dependencies detected for LEDS_TRIGGER_DISK
  Depends on [n]: NEW_LEDS [=y] && LEDS_TRIGGERS [=y] && ATA [=n]
  Selected by [y]:
  - ADB_PMU_LED_DISK [=y] && MACINTOSH_DRIVERS [=y] && ADB_PMU_LED [=y] && LEDS_CLASS [=y]

Fix this by making ADB_PMU_LED_DISK depend on ATA.

Seen on both PPC32 and PPC64.

Fixes: 0e865a80 ("macintosh: Remove dependency on IDE_GD_ATA if ADB_PMU_LED_DISK is selected")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230223014241.20878-1-rdunlap@infradead.org


Signed-off-by: Sasha Levin <sashal@kernel.org>

parent e2dd8bba

drivers/macintosh/Kconfig

+1 −0

Original line number	Original line	Diff line number	Diff line
	@@ -86,6 +86,7 @@ config ADB_PMU_LED

	config ADB_PMU_LED_DISK		config ADB_PMU_LED_DISK
	bool "Use front LED as DISK LED by default"		bool "Use front LED as DISK LED by default"
			depends on ATA
	depends on ADB_PMU_LED		depends on ADB_PMU_LED
	depends on LEDS_CLASS		depends on LEDS_CLASS
	select LEDS_TRIGGERS		select LEDS_TRIGGERS